docs: correct MCP server and AI agent config framing in overview#66
Conversation
Remove inaccurate "define tools in YAML" / "define behaviors in YAML" claims. MCP server tools are discovered automatically after picking a managed type or registering a self-managed server; agents are configured declaratively (system prompt, model, tools), not authored in YAML. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for redpanda-agentic-data-plane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PR ReviewFiles reviewed: 1 .adoc file ( What this PR doesReplaces inaccurate "you define tools in YAML" / "you define behaviors in YAML" claims in the ADP overview page. The MCP servers section now describes the actual workflow (pick a managed type from the marketplace, or register a self-run server; tools discovered automatically). The AI agents section now describes declarative configuration (system prompt, model, tools). "Prebuilt connectors" → "prebuilt tools and integrations" to drop a residual Redpanda Connect reference. Critical issues (must fix)
Suggestions (should consider)
Impact on other files
What works well
🤖 Generated with Claude Code via |
Incorporate PR review: fix the cross-page inconsistency where agents-overview.adoc still presented agent tools as "prebuilt Redpanda Connect connectors" after the overview switched to neutral "prebuilt tools and integrations" wording. Extend the fix to the MCP server landing pages for consistent vocabulary. - adp-overview.adoc: "register a server you already run" -> "register a self-managed server"; "a marketplace" -> "the marketplace" - agents-overview.adoc: drop "prebuilt connectors" agent-tool framing; tools are sourced through MCP servers; keep Redpanda Connect as the named data/streaming engine and the bidirectional pipeline-agent integration - mcp-servers.adoc, connect/index.adoc: "managed connector" -> "managed type", matching the canonical taxonomy in mcp-overview.adoc Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks for the review. Addressed both items in-PR (commit Critical — Suggestion 1 — taxonomy alignment on Suggestion 2 — sentence split + Extra (consistency sweep): Normalized "managed connector" → "managed type" in |
What
Fixes inaccurate configuration framing in the ADP overview page (
adp-overview.adoc) and aligns the pages it links to. A review flagged that "you define tools in YAML" was wrong for MCP servers, and the same YAML framing had leaked onto AI agents. A follow-up review flagged that the next-click page (agents-overview.adoc) still used the "prebuilt Redpanda Connect connectors" framing this PR removes, so the overview and its destination contradicted each other.Changes
adp-overview.adoc): Removed "You define tools in YAML." You pick a managed type from the marketplace and configure it, or register a self-managed server, and the server's tools are discovered automatically.adp-overview.adoc): Removed "you define behaviors in YAML." Agents are configured declaratively (system prompt, model, tools), not authored in YAML. "Prebuilt connectors" → "prebuilt tools and integrations."agents-overview.adoc): Dropped the "prebuilt Redpanda Connect connectors" agent-tool framing; tools are now sourced through MCP servers. Redpanda Connect stays named as the underlying data/streaming engine, and the bidirectional pipeline↔agent integration is unchanged.mcp-servers.adoc,connect/index.adoc): "managed connector" → "managed type", matching the canonical taxonomy inmcp-overview.adoc.No new Redpanda Connect references; the
connect:xrefs are internal ADP module references and remain correct.Preview pages
🤖 Generated with Claude Code