GCP BigLake support in Cloud#1731
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR updates documentation and configuration metadata to rebrand GCP BigLake as Lakehouse throughout the Redpanda Iceberg integration guide. Changes include updating the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs-data/property-overrides.json`:
- Line 986: Update the description string for the Iceberg catalog authentication
mode to correct the spelling mistake: replace "unconditonally" with
"unconditionally" in the description value that begins "The authentication mode
for client requests made to the Iceberg catalog..." so the property description
(the authentication mode description block) reads with the correct spelling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 37b0a12a-cefb-4c4a-9a1b-628f3f333c38
📒 Files selected for processing (3)
docs-data/property-overrides.jsonmodules/ROOT/nav.adocmodules/manage/pages/iceberg/iceberg-topics-gcp-biglake.adoc
| :personas: developer, sre | ||
|
|
||
| ifdef::env-cloud[] | ||
| :rp_version: 26.1 |
There was a problem hiding this comment.
SME reviewer: please confirm version requirement
There was a problem hiding this comment.
I see no reason 25.3 wouldn't work as well but testing was focused on 26.1. Leave as is for now.
Feediver1
left a comment
Feediver1
left a comment
There was a problem hiding this comment.
Automated docs-standards review
Overall: Clean, well-executed rebrand (BigLake → Google Lakehouse for Apache Iceberg) plus the new gcp auth mode and Cloud GA support. SME review (ncole) is approved and all inline comments are addressed. One merge blocker remains, plus a few verify-before-merge items.
Critical (must fix before merge)
local-antora-playbook.yml:21— cloud-docs source points at a feature branch:Revert to- url: https://github.com/redpanda-data/cloud-docs branches: 'DOC-2221-biglake-cloud-docs' # was: main
branches: mainbefore merge (already flagged with a "commit before merge" suggestion). Merging as-is breaks local/preview builds for everyone.
Suggestions / verify before merge
- Self-managed config consistency — The SME's "we aren't using oauth2 on GCP yet" feedback was addressed by removing
iceberg_rest_catalog_oauth2_server_urifrom the Cloudrpkblock. Confirm the self-managed config example also omitsoauth2_server_uriand usesauthentication_mode=gcp, so the two paths on the same page don't contradict each other. - Iceberg modes xref — The link was changed to
xref:manage:iceberg/specify-iceberg-schema.adoc[]while the prose still says "for more details on Iceberg modes." Verify that target exists and is the right page for modes (vs. schema). - Generated partial —
modules/reference/partials/properties/cluster-properties.adocwas edited directly. Source of truth isdocs-data/property-overrides.json(also edited, consistently). Confirm the partial was regenerated from the override rather than hand-synced, so a future regen doesn't clobber it. - Link domain consistency — Mixed
cloud.google.com/biglake/...anddocs.cloud.google.com/lakehouse/...links. Worth a consistency pass now that the page is otherwise on the new Lakehouse paths. - Prerequisites rendering — The restructured list nests a cloud-only
**bullet between the GCP-project*bullet and its+continuation paragraph. Quick rendered-preview check that the "If you do not have permissions…" paragraph attaches to the right list item in both builds. - PR title — Still reads "GCP BigLake support in Cloud"; consider updating to "Lakehouse" to match the content.
Impact on other files (limited — repo not checked out locally)
use-iceberg-catalogs.adocandnav.adoc— already updated in this PR. ✅- What's New — Cloud support moved Beta → Supported and a new
gcpauth mode was added. Verify whetherwhats-new-cloud.adocneeds a corresponding entry (none in this PR). - Filename unchanged, so existing xrefs to the page should still resolve.
CodeRabbit
- The one actionable item (
unconditonally→unconditionallytypo) is already fixed in this PR. No outstanding bot findings.
What works well
- Learning objectives: 3 max, action verbs, checkbox format, defined inside the single-source tag so they carry to cloud-docs.
- Property description updated consistently in both the override JSON and the generated partial.
- Disciplined block-level
ifdef/ifndef::env-cloud[]single-sourcing; BYOC vs BYOVPC paths clearly separated; the leftover// TODOabouticeberg_dlq_table_suffixwas properly resolved, not shipped. - All SME inline comments (version requirement, outdated
gcloudlink,alpha biglakecommand, oauth2 removal) addressed.
🤖 Generated with Claude Code
|
@kbatuigas Looks like you already fixed the critical fix, so suggestions are up to you. |
|
Looks good assuming we call out which clusters are supported and when users need to run rpk byoc apply to existing cluster to get new functionality. |
kbatuigas
deleted the
DOC-2221-document-feature-support-gcp-biglake-as-rest-cata
branch
4 participants
Description
This pull request updates the documentation to reflect the rebranding of "Google BigLake" to "Google Lakehouse for Apache Iceberg" and adds support for GCP authentication mode in the Iceberg REST catalog integration. The changes ensure terminology is consistent across documentation, clarify integration steps for both self-managed and cloud environments, and update configuration instructions for Redpanda clusters using Lakehouse as a REST catalog.
Key changes include:
Documentation Rebranding and Consistency:
Iceberg REST Catalog Integration Enhancements:
gcpauthentication mode in theiceberg_rest_catalog_authentication_modeproperty, allowing Redpanda to use GCP VM instance metadata credentials for authenticating with the Iceberg REST catalog.Guide Improvements and Clarifications:
Reference and Link Updates:
Configuration Property Updates:
These changes ensure users have up-to-date guidance for integrating Redpanda with Google Lakehouse for Apache Iceberg, supporting the latest authentication methods and aligning with Google's current product offerings.
Resolves DOC-2221
Review deadline: 10 Jun
Page previews
Cloud: Use Iceberg Topics with GCP Lakehouse
Self-Managed: Use Iceberg Topics with GCP Lakehouse
Cluster Configuration Properties
Checks