Skip to content

Update rpk-group.adoc#1746

Closed
goojal wants to merge 1 commit into
redpanda-data:mainfrom
goojal:patch-1
Closed

Update rpk-group.adoc#1746
goojal wants to merge 1 commit into
redpanda-data:mainfrom
goojal:patch-1

Conversation

@goojal

@goojal goojal commented Jun 15, 2026

Copy link
Copy Markdown

Fix a small typo.

Description

Resolves https://redpandadata.atlassian.net/browse/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Fix a small typo.
@goojal goojal requested a review from a team as a code owner June 15, 2026 08:15
@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

Deploy Preview for redpanda-docs-preview ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1759261
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/6a2fb491e934b20008122440
😎 Deploy Preview https://deploy-preview-1746--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Two corrections are made to modules/reference/pages/rpk/rpk-group/rpk-group.adoc. The duplicated word "are" is removed from the consumer group partition scaling sentence ("than there are are" → "than there are"). Additionally, the missing // end::single-source[] closing tag marker is added at line 79 to properly close the single-source block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and does not clearly convey the specific change made; it merely states the filename without describing the actual fix. Use a more descriptive title that specifies the change, such as 'Fix duplicate word and close tag in rpk-group.adoc' to clearly communicate the fix at a glance.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description follows the template structure with title, description section, page previews, and checkbox selections. However, the JIRA ticket reference is incomplete (missing ticket number).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

micheleRP
micheleRP previously approved these changes Jun 23, 2026

@micheleRP micheleRP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR! I'll go ahead and merge this!

@micheleRP micheleRP dismissed their stale review June 23, 2026 23:41

Superseded by the upstream source fix (redpanda-data/redpanda#30898); this generated page will be regenerated by the rpk docs automation.

@micheleRP micheleRP closed this Jun 23, 2026
@micheleRP

Copy link
Copy Markdown
Contributor

Thank you for catching this, @goojal! 🙏

After a closer look: this page (rpk-group.adoc) is auto-generated from the rpk group help text in the redpanda source, and we're about to land automated regeneration for rpk docs (#1733). An edit to the generated .adoc would unfortunately be overwritten the next time the page regenerates.

So I've fixed it at the source instead, which corrects both rpk group -h and the generated docs: redpanda-data/redpanda#30898. Full credit to you for the find — it's referenced in that PR.

I closed this one since the source fix supersedes it, but we really appreciate the contribution. Please keep them coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants