Skip to content

Fix: clear profession icons for non-item tooltips (pfUI-compatible)#2

Open
gitGrom wants to merge 1 commit intorefaim:masterfrom
gitGrom:fix/clear-icons-non-item
Open

Fix: clear profession icons for non-item tooltips (pfUI-compatible)#2
gitGrom wants to merge 1 commit intorefaim:masterfrom
gitGrom:fix/clear-icons-non-item

Conversation

@gitGrom
Copy link

@gitGrom gitGrom commented Aug 14, 2025

Problem
After hovering an item reagent, the profession icons remain (“stick”) when the next
tooltip is a unit/spell (e.g., pet, NPC) until a non-crafting item is hovered.

Cause
Icons are only hidden on subsequent item tooltips; non-item tooltip code paths
reuse the same tooltip but don’t clear the icons.

Fix

  • Clear icons before building non-item tooltips: SetUnit, SetSpell, SetTrainerService.
  • Also clear on ClearLines() and OnHide().
  • Hook both stock GameTooltip and pfUI tooltip frames when present.
  • No behavior change for item tooltips; no saved data changes.

Tested
Vanilla/Turtle with pfUI tooltips:

  1. Hover Copper Bar → icons appear.
  2. Hover unit (bank mule/pet) → icons disappear immediately.
  3. Hover item again → icons return.

Fixes #<1>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments