Seqcol store app factory - #101
Open
nsheff wants to merge 21 commits into
Open
Conversation
add_sequence_collections_from_fastas returns an ImportReport rather than a list of (metadata, was_new) pairs, and PyImportReport defines neither __iter__ nor __getitem__, so iterating it and calling len() on it both raised TypeError. Read .collections for the per-file results, and surface the report's per-run ingest counters in the JSON output. Also update the stats docstring, which still advertised n_collections_loaded: that key is now n_collections_in_memory, and the docstring now says what those gauges actually measure -- RAM residency at the moment stats() is called, typically 0 for a disk-backed store -- so they stop being read as ingest counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves seqcolapi server code into the refget package proper, as a module with gated.
also some other improvements to gating and stuff.