Finish Subscriptions to Flare rename and fix runtime defects#2
Open
rawritude wants to merge 1 commit into
Open
Finish Subscriptions to Flare rename and fix runtime defects#2rawritude wants to merge 1 commit into
rawritude wants to merge 1 commit into
Conversation
Rename the public product to the Flare oracle across the Flare pages and the DAO blueprint; the client, contract and webhook identifiers stay "subscription". Runtime fixes verified against @reflector/subscription-client 0.5.3 and confirmed on Mainnet: - supply both callTimeout and the client's misspelled callTiemout key (the site was silently running at the 30s default instead of 600s) - set the create-form deposit default and minimum to 30 XRF (creation burns 20 and retains 10) - display the remaining balance via fromStroops instead of raw stroops - normalize and de-duplicate stored u64 subscription ids - validate the webhook URL and the threshold/heartbeat ranges before opening the wallet - guard against a second create or cancel submit while one is pending - show a load error with retry instead of an infinite spinner - fix the misspelled "tesntet" network key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the public Subscriptions → Flare rename (the
/flareroute,/subscriptionredirect and nav label already exist) and fixes narrow runtime defects. Client, contract and webhook identifiers staysubscription.Verified against
@reflector/subscription-client@0.5.3and confirmed on Mainnet (owner-signed create + cancel).Rename (copy only)
/subscription/add→/flare/addredirectRuntime fixes
callTimeoutand the client's misspelledcallTiemoutkey (the site was silently running at the 30s default instead of 600s)fromStroopsinstead of raw stroopstesntetnetwork keyTests:
node --test tests/flare-runtime.test.cjs