Proxy /explorer in the dev server to fix local CORS#5
Open
rawritude wants to merge 1 commit into
Open
Conversation
The price-display widgets fetch api.stellar.expert, which rejects cross-origin browser requests with a 403, so `pnpm dev-server` throws "Failed to fetch" from localhost. Proxy /explorer to api.stellar.expert server-side in development (changeOrigin) and select a same-origin path in app.js when NODE_ENV is development. Production API routing is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer-experience fix for local development.
The site is a client-rendered SPA whose price-display widgets fetch
api.stellar.expert, which rejects cross-origin browser requests with a 403. As a resultpnpm dev-serverthrows "Failed to fetch" runtime errors when the site is opened fromlocalhost. On production the fetch is effectively same-origin, so this only affects local development.This proxies
/explorertoapi.stellar.expertserver-side in the dev server (changeOrigin, which drops the browserOriginand clears the 403), and selects a same-origin path inapp.jswhenNODE_ENV === 'development'. Production API routing is unchanged.