fix(docs): remove dead docs breadcrumb segment filter#6427
Conversation
Greptile SummaryThis PR removes a dead
Confidence Score: 5/5Safe to merge — removes a now-dead special-case filter with no behavioral risk on normalized paths, and the change is covered by a new regression test. The change is a trivial one-liner that deletes a guard condition that was already rendered inert by upstream path normalization. The new regression test directly exercises the removed branch, and the existing test suite continues to pass. No logic is restructured and no new code paths are introduced. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into fix-docs-breadc..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
|
@carlosabadia is this something we need still or did your recent breadcrumb changes also fix this? |
All Submissions:
Type of change
Changes To Core Features:
Description
Follow-up to #6359.
breadcrumb(...)still had a hard-codedsegment != "docs"filter even though docs paths are normalized earlier. That condition is now dead and can hide a valid segment mapping if a docs-prefixed path is passed through.This PR removes that special-case filter so breadcrumb segments are derived uniformly from non-empty path segments.
Tests
Added regression test:
docs/app/tests/test_breadcrumb.py::test_breadcrumb_keeps_docs_segment_when_present_in_pathValidation run:
uv run --no-sync ruff check docs/app/reflex_docs/templates/docpage/docpage.py docs/app/tests/test_breadcrumb.pyuv run --no-sync pytest docs/app/tests/test_breadcrumb.py -quv run --no-sync pytest docs/app/tests/test_routes.py -q