Skip to content

Update LiteralTrackCursorAxis tooltip component prop in reflex intern…#6654

Merged
masenf merged 1 commit into
mainfrom
carlos/update-tooltip-axis-prop
Jun 11, 2026
Merged

Update LiteralTrackCursorAxis tooltip component prop in reflex intern…#6654
masenf merged 1 commit into
mainfrom
carlos/update-tooltip-axis-prop

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

…al components

@carlosabadia carlosabadia requested a review from a team as a code owner June 11, 2026 10:43
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jun 11, 2026
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects the LiteralTrackCursorAxis type alias in the internal tooltip component to match the Base UI Tooltip.Root API, replacing the invalid "bottom" literal with "both".

  • The old type was Literal["none", "bottom", "x", "y"]; "bottom" is not a valid value for trackCursorAxis in Base UI and "both" was missing. The Base UI docs define the prop as 'none' | 'x' | 'y' | 'both'.
  • The fix brings the Python type guard in sync with the upstream JS library, preventing users from accidentally passing "bottom" (which would be silently accepted at the Python layer but ignored or cause unexpected behavior at runtime).

Confidence Score: 5/5

Safe to merge — the change is a single-line correction to a type alias that now matches the upstream Base UI library's documented API.

The only change is swapping an incorrect literal string ("bottom") for the correct one ("both") in a type alias used as a prop type guard. The Base UI docs confirm 'none' | 'x' | 'y' | 'both' are the only valid values, so this fix closes a gap between the Python wrapper and the underlying JS component.

No files require special attention.

Important Files Changed

Filename Overview
packages/reflex-components-internal/src/reflex_components_internal/components/base/tooltip.py Fixes LiteralTrackCursorAxis type alias by replacing invalid "bottom" value with correct "both" — aligns with Base UI Tooltip.Root trackCursorAxis API ('none'

Reviews (1): Last reviewed commit: "Update LiteralTrackCursorAxis tooltip co..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/update-tooltip-axis-prop (9fdd6fa) with main (475844e)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@masenf masenf merged commit 317dcfc into main Jun 11, 2026
106 checks passed
@masenf masenf deleted the carlos/update-tooltip-axis-prop branch June 11, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants