ENG-9845: Update selects style in book a demo to match inputs style#6667
Conversation
Greptile SummaryThis PR restylings the four
Confidence Score: 3/5The select fields will have no visible focus indicator after this change, which breaks keyboard-accessibility for the entire demo form. The ClassNames.DIV focus ring styles (focus-within:shadow-*, focus-within:border-primary-a6) are borrowed from the input wrapper div, where they work because a child input receives focus. Applied directly to a select element, :focus-within never matches — the select focuses itself, not a child. At the same time, ClassNames.INPUT adds outline-none to suppress the browser default ring, and appearance-none strips native styling. Together these leave all four select fields with zero focus indicator, a meaningful regression for keyboard users on a marketing-critical form. packages/reflex-components-internal/src/reflex_components_internal/blocks/demo_form.py — the select_field styling needs a focus: fallback or a custom wrapper pattern. Important Files Changed
Reviews (1): Last reviewed commit: "ENG-9845: Update selects style in book a..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
No description provided.