Skip to content

Fix render tree line in MCP/Skills sidebar sections#6670

Open
carlosabadia wants to merge 1 commit into
mainfrom
carlos/fix-mcp-not-showing-lines
Open

Fix render tree line in MCP/Skills sidebar sections#6670
carlosabadia wants to merge 1 commit into
mainfrom
carlos/fix-mcp-not-showing-lines

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jun 19, 2026
@carlosabadia carlosabadia requested review from a team and Alek99 as code owners June 19, 2026 10:20
@greptile-apps

greptile-apps Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the missing vertical connecting line in the MCP/Skills sidebar sections by introducing a decorative absolutely-positioned li element and adding relative positioning to the parent ul container when connected_line=True.

  • An empty li acting as a 1 px vertical rule (absolute left-[3rem] top-0 bottom-0 w-px bg-secondary-4) is prepended to the item list; relative on the ul gives it the correct containing block so the line spans all items.
  • The change is compile-time only (Python bool check), so there is no runtime or rendering overhead.

Confidence Score: 4/5

Safe to merge; the change is a small, isolated CSS layout fix with no logic changes.

The fix is straightforward and well-scoped. The only note is that the decorative li element is missing aria-hidden=true, which could cause screen readers to announce an empty list item, but this does not affect functionality.

docs/app/reflex_docs/templates/docpage/sidebar/sidebar.py — the new decorative li element could benefit from aria-hidden.

Important Files Changed

Filename Overview
docs/app/reflex_docs/templates/docpage/sidebar/sidebar.py Adds a decorative vertical-line li element and relative positioning to ul when connected_line=True, fixing the render-tree line in MCP/Skills sidebar sections.

Reviews (1): Last reviewed commit: "Fix render tree line in MCP/Skills sideb..." | Re-trigger Greptile

Comment thread docs/app/reflex_docs/templates/docpage/sidebar/sidebar.py
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/fix-mcp-not-showing-lines (3d851ab) with main (019bf0c)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant