Update base API executor prompt on how to handle errors and edge cases#16
Draft
tomaz-lc wants to merge 1 commit into
Draft
Update base API executor prompt on how to handle errors and edge cases#16tomaz-lc wants to merge 1 commit into
tomaz-lc wants to merge 1 commit into
Conversation
empty response or subprocess failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates base api executor prompt to better handle various edge cases and errors.
Background, Context
In the wild, I noticed that we sometimes don't correctly handle various edge cases and error scenarios, things such as:
generate_lcql_queryreturningnil)STDERR: Traceback (most recent call last): File "<string>", line 4, in <module> ModuleNotFoundError: No module named 'skills.limacharlie_call')In both of those cases, it looked like we proceeded (in first case it hallucinated a query) where we shouldn't have.
Notes
This change may have a negative impact in other places so we will need to deploy it, test it will and observe for any issues related to this change.