Wire up validator in CI + baseline ignore-list#88
Merged
Conversation
- .github/workflows/validate.yml runs scripts/validate.py on every PR and on push to master. Uses fetch-depth: 0 so the baseline-regression check can resolve master. - .validate-ignore suppresses 4 pre-existing errors so master goes green immediately. New regressions still fail. Tracked in refractionPOINT/tracking#4229. - BREAKING.md documents the lc-essentials → lc-advanced-skills carve-out from #85; the validator greps it to allow legitimate skill removals. - validate.py now resolves origin/master as a fallback for environments (CI, fresh clones) where 'master' is not a local branch. Refs refractionPOINT/tracking#4229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/validate.ymlrunsscripts/validate.pyon every PR and push to master.validate-ignoresuppresses 4 pre-existing errors so master goes green immediately; new regressions still failBREAKING.mddocuments the lc-essentials → lc-advanced-skills carve-out from Add lc-compliance plugin (seven compliance frameworks) #85 and is read by the baseline checkvalidate.pyfalls back toorigin/masterso the baseline check works in CI / fresh clonesStrategy
Baseline-and-fail-on-new. Existing issues in the repo would have failed CI on day one (5 errors flagged when this validator was first run). Listing them in
.validate-ignorelets master pass immediately while still failing any new regression. Each entry has a comment pointing at the underlying issue; remove the line when the issue is fixed.Test
Follow-up
Once this lands and the
validatecheck has reported once, add it to required status checks onmasterso future PRs can't merge if validation fails. Track and resolve the 4 suppressed entries (and the deletedlimacharlie-callskill) in refractionPOINT/tracking#4229.Refs refractionPOINT/tracking#4229