adding assume roll to sqs-files go code#256
Open
0BL1V10N-55 wants to merge 4 commits into
Open
Conversation
Added assume roll code to sqs-files client.go code. 1. Local Org (Same Account) - Without Role Assumption If you don't provide role_arn, it works exactly as before: → Uses the access_key/secret_key directly to access resources in the same AWS account 2. Cross-Org (Different Account) - With Role Assumption If you do provide role_arn, it assumes the role: → Uses the access_key/secret_key to assume the role, then uses the assumed role credentials Why Both Work: Looking at client.go:125-137, the logic the role assumption is opt-in. If role_arn is empty or omitted, it skips that entire block and just uses your base credentials. No breaking changes!
Cloudtrail records arrive in a 5min array containing multiple records, added code to enable splitting the array into separate json events.
The sqs-files adapter now supports automatic splitting of CloudTrail events that contain multiple records.
found a issue were the assume role was requested more than once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added assume roll code to sqs-files client.go code.
Description of the change
→ Uses the access_key/secret_key to assume the role, then uses the assumed role credentials Why Both Work:
Looking at client.go:125-137, the logic
the role assumption is opt-in. If role_arn is empty or omitted, it skips that entire block and just uses your base credentials. No breaking changes!
Type of change