fix(validate): correct handling of openssl_verify return value#9
Open
DenisZhadan wants to merge 1 commit into
Open
fix(validate): correct handling of openssl_verify return value#9DenisZhadan wants to merge 1 commit into
DenisZhadan wants to merge 1 commit into
Conversation
Update signature validation to check `$ok !== 1` instead of `$ok === 0`. `openssl_verify` returns: - 1 → signature is valid - 0 → signature is invalid - -1/false → error occurred This change ensures errors are not misclassified and invalid signatures are properly detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update signature validation to check
$ok !== 1instead of$ok === 0.openssl_verifyreturns:This change ensures errors are not misclassified and invalid signatures are properly detected.