Skip to content

Conversation

@JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Jan 6, 2026

Noticed that I'd added this toast for save fails in 0.28.1 (#727), but forgot about delete fails!
image

Also cleanup duplicate console error logging on notify sends, manual version saves, and order saves

draft whilst I'm refactoring (separate branch) struct creation to handle types being in the defaults (#583). With that I've also split out the docker registries into their own struct, so should be able to add in support for ECR (#546) quite simply once I've got all the tests setup for these Docker structs

@JosephKav JosephKav added enhancement New feature or request javascript Pull requests that update Javascript code labels Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.96%. Comparing base (dbec1f6) to head (fc8d459).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         137      137           
  Lines        9224     9224           
=======================================
  Hits         9128     9128           
  Misses         73       73           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav force-pushed the feat/ui/error-toast-for-failed-service-delete branch 3 times, most recently from 074edae to feedb6e Compare January 12, 2026 18:25
@JosephKav JosephKav force-pushed the feat/ui/error-toast-for-failed-service-delete branch from feedb6e to fc8d459 Compare January 12, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants