[bulk][split-218 #179] load: require PITR enabled (safety gate) (bu-9yy) - #43
Closed
relentlesscol wants to merge 1 commit into
Closed
[bulk][split-218 #179] load: require PITR enabled (safety gate) (bu-9yy)#43relentlesscol wants to merge 1 commit into
relentlesscol wants to merge 1 commit into
Conversation
Load now calls validate_tables with pitr_enabled=True, refusing to run against tables without Point-in-Time Recovery — same safety gate already protecting delete. Adds unit test (TDD) and e2e test for the new exit-with-error path. Fixes awslabs#179
Owner
Author
|
Promoted to upstream: awslabs#224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue awslabs#179. Refuse to run load if the target table does not have Point-in-Time Recovery enabled — safety gate against accidental data loss.
TDD REQUIRED: (1) Write a failing unit test that asserts load aborts with clear error when PITR is off. (2) Implement the check. (3) make test must pass. (4) This changes command behavior (new exit-with-error path) — add e2e test. Single-issue PR.
Files: client/src/runner.py. Tests: tests/client/ + tests/e2e/commands/.
Implementation notes
Implemented: load now requires PITR enabled (pitr_enabled=True in validate_tables call). Unit test + e2e test added. All 1325 tests pass.
Refinery handoff
bu-9yy(task, P2)polecat/bu-9yymainmainvia Gastown Refinery.