[bulk][split-218 #91] Install faker only for fill verb (bu-56r) - #46
Closed
relentlesscol wants to merge 1 commit into
Closed
[bulk][split-218 #91] Install faker only for fill verb (bu-56r)#46relentlesscol wants to merge 1 commit into
relentlesscol wants to merge 1 commit into
Conversation
Move faker from Glue job DefaultArguments (installed on every run) to a runtime argument injected only when XAction=fill. This eliminates the pip install overhead for all other verbs (load, copy, delete, find, etc). Fixes awslabs#91
Owner
Author
|
Promoted to upstream: awslabs#223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue awslabs#91. Only install the faker dependency when the fill verb is invoked — speeds up startup for all other commands.
TDD REQUIRED: (1) Write a failing unit test that asserts faker is not imported/installed for non-fill verbs. (2) Implement conditional install. (3) make test must pass. Single-issue PR.
Files: client/src/python_modules/. Tests: tests/client/.
Implementation notes
Implemented: faker now installed only at runtime for fill verb. Removed from bootstrap DefaultArguments, injected in _get_glue_job_arguments when XAction=fill. All 1325 tests pass.
Refinery handoff
bu-56r(task, P2)polecat/bu-56rmainmainvia Gastown Refinery.