[bulk][split-218 #137] Clean error messages instead of stack traces (bu-9jr) - #47
Closed
relentlesscol wants to merge 1 commit into
Closed
[bulk][split-218 #137] Clean error messages instead of stack traces (bu-9jr)#47relentlesscol wants to merge 1 commit into
relentlesscol wants to merge 1 commit into
Conversation
…awslabs#137) When a command fails due to bad parameters or runtime errors in the driver, users now see a clean human-readable error message instead of a raw Python stack trace. The run() method catches exceptions from the job execution path and calls sys.exit() with a formatted message. TDD: wrote failing unit tests first, then implemented the fix. Added e2e tests verifying no tracebacks for common bad-input scenarios.
Owner
Author
|
Promoted to upstream: awslabs#227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue awslabs#137. When a command fails due to bad parameters in the driver, show a clean human-readable error message instead of a Python stack trace.
TDD REQUIRED: (1) Write a failing unit test that asserts bad-param errors produce clean messages (no traceback). (2) Implement the error handling. (3) make test must pass. (4) This changes user-facing error output — add e2e test. Single-issue PR.
Files: client/src/runner.py. Tests: tests/client/ + tests/e2e/commands/.
Implementation notes
Implemented: clean error messages in runner.py instead of stack traces (issue awslabs#137). TDD unit tests + e2e test added. All 1328 tests pass.
Refinery handoff
bu-9jr(task, P2)polecat/bu-9jrmainmainvia Gastown Refinery.