fix: code review fixes — .dockerignore, -trimpath, -race, rand.Read error handling - #5
Merged
Conversation
… handling - Add .dockerignore to reduce Docker build context - Add -trimpath to Makefile build and Dockerfile for reproducible builds - Add -count=1 -race to Makefile test target - Handle crypto/rand.Read errors in auth package (New, GenerateToken, GenerateOTP, GenerateHandle) - Add .gitignore entries for build artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review fixes addressing build quality, security, and correctness:
Changes
.dockerignore: Added to reduce Docker build context size (excludes.git,*.db, build artifacts, etc.)-trimpath: Added to Makefilebuildtarget and Dockerfile for reproducible builds (removes absolute paths from binary)-count=1 -race: Added to Makefiletesttarget for race detector coveragerand.Readerror handling: Allcrypto/rand.Readcalls ininternal/auth/auth.gonow properly check and handle errors (inNew(),GenerateToken(),GenerateOTP(),GenerateHandle()).gitignore: Added entries for build artifactsTesting
go vet ./...passes ✅go test ./...passes ✅