fix: add missing cmd/notable/main.go entry point - #2
Merged
Conversation
The cmd/notable/main.go file was missing from the initial commit, causing all CI build steps to fail (go build ./cmd/notable had no target). This adds the main entry point following the same pattern as linksmith and taskpilot: flag/env config, store initialization, auth setup, and HTTP server startup. Also fixes .gitignore to use /notable instead of notable so the cmd/notable directory is not ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
cmd/notable/main.gofile was missing from the initial commit, causing all CI build steps to fail. Thego build ./cmd/notablecommand had no target to build.Additionally,
.gitignorehadnotable(without leading slash) which would ignore thecmd/notabledirectory if it were ever present.Fix
cmd/notable/main.gofollowing the same pattern as linksmith and taskpilot: flag/env config (-addr,-db,-secretwithNOTABLE_ADDR,NOTABLE_DB,NOTABLE_SECRETenv vars), store initialization, auth setup, and HTTP server startup..gitignoreto use/notableinstead ofnotableso thecmd/notabledirectory is not ignored.Verification
go vet ./...✅go test ./... -count=1✅CGO_ENABLED=0 go build -trimpath ./cmd/notable✅