Conversation
🚨 Test Coverage Below 85% 🚨The current test coverage does not meet the required 85% threshold. Please improve the following coverage metrics:
|
Signup was failing with Prisma transaction timeout errors under seed and concurrent requests. Root cause: - Email sending was executed inside the Prisma transaction - This kept DB connections open longer than needed - Concurrent signups + bcrypt hashing exhausted the Prisma connection pool - Resulted in: “Transaction API error: Unable to start a transaction in the given time” Changes: - Moved verification email sending outside the Prisma transaction - Limited transaction scope to DB writes only (user + token) - Added Prisma transaction timeout/maxWait options - Added safe mail error handling with try/catch and logging - Signup no longer fails if email sending fails Result: - Shorter transactions - Lower connection pool pressure - Seed and concurrent signup now stable - Email failures handled without breaking account creation
- CreateShopDto - ShopResponseDto - toShopResponseDto()
- CreateProductDto - UpdateProductDto - ProductResponseDto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.