fix(devices): show empty state instead of spinner when filtered results are empty#1065
Merged
JamieRuderman merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudSync.all()fires (network reconnect, wake-from-sleep, window refocus), it was resettingfrom: 0and only re-fetching the first 50 devices — discarding all "Load More" progress. Now it re-fetches all previously loaded pages in one request and restores the pagination position afterward.Details
Pagination preservation (
CloudSync.ts)The root cause of the user complaint ("I click Load More several times, edit a device, go back, and I'm back to the first 50") was
cloudSync.all()unconditionally settingfrom: 0. This gets triggered by network reconnect/sleep/focus events — not the save itself, but the time spent editing gives these events a chance to fire.The fix reads the current pagination state before the sync, temporarily sets
sizeto cover all loaded devices (from + size), fetches them in one request, then restores the originalfrom/sizevalues.Row count (
LoadMore.tsx)Added a "X of Y" label next to the Load More button. Also migrated from deprecated
makeStylestosxprop.Test plan