@remotion/studio-server: Fix deleting the last keyframe#7900
Merged
Conversation
Co-authored-by: Jonny Burger <hi@jonny.io>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a focused bugfix for deleting the last keyframe on sequence, color, and effect props, plus regression tests.
update-keyframes.ts:removeKeyframenow returns the removed keyframe's staticoutputexpression when zero keyframes remain, instead of emitting an emptyinterpolate(frame, [], [])call.optimistic-delete-keyframe.ts:removeKeyframeFromPropStatusnow returns acanUpdate: true, codeValuestatus when the last keyframe is removed, instead of keeping a stalekeyframedstatus.- Tests: Added regression coverage for sequence props, color props, effect props, and optimistic deletion.
Kimi K2 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7898
Summary
interpolate()calls.keyframedstatus when the final keyframe is removed.Testing
bun test src/test/update-keyframes.test.tsinpackages/studio-serverbun test src/test/optimistic-delete-keyframe.test.tsinpackages/studio-sharedwidth: 320instead ofinterpolate(frame, [], [])bun run buildbun run formattingbun run stylecheck(fails only on documented local Go 1.22.2 vs@remotion/lambda-goGo >= 1.23 requirement)bun run lintinpackages/studio-serverbun run lintinpackages/studio-sharedbun run formattinginpackages/studio-serverbun run formattinginpackages/studio-sharedManual UI note
packages/exampleStudio successfully, but browser preview manual testing is blocked in this VM by a WebGL/GPU error, so no UI artifact is attached.