Skip to content

@remotion/studio: Fix enum dropdown outside-clicks #7902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jroxas44 wants to merge 1 commit into from
+1 −1
Closed

@remotion/studio: Fix enum dropdown outside-clicks #7902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/studio/src/components/NewComposition/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export const Combobox: React.FC<{
</button>
{portalStyle
? ReactDOM.createPortal(
<div style={fullScreenOverlay}>
<div style={fullScreenOverlay} onPointerDown={onHide}>
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onPointerDown={onHide} on the overlay will also catch bubbled pointerdown events from the dropdown menu content (the portalStyle div and MenuContent inside it), causing the dropdown to close immediately when the user tries to click any item.

ContextMenu.tsx avoids this by calling e.stopPropagation() in onMenuPointerDown on the inner portalStyle div. ComboBox.tsx needs the same protection.

Technical details 
# Missing stopPropagation on ComboBox menu content

## Affected sites
- `packages/studio/src/components/NewComposition/ComboBox.tsx:270` — `onPointerDown={onHide}` on `fullScreenOverlay`
- `packages/studio/src/components/NewComposition/ComboBox.tsx:273` — inner `portalStyle` div lacks `onPointerDown` handler

## Required outcome
- Clicking the dropdown backdrop closes the dropdown.
- Clicking inside the dropdown menu content does **not** close the dropdown.

## Suggested approach
Add `onPointerDown={(e) => e.stopPropagation()}` to the inner `<div style={portalStyle}>` in `ComboBox.tsx`, mirroring the pattern used in `ContextMenu.tsx` (`onMenuPointerDown`).

```tsx
<div style={portalStyle} onPointerDown={(e) => e.stopPropagation()}>
```

<div style={outerPortal} className="css-reset">
<HigherZIndex onOutsideClick={onHide} onEscape={onHide}>
<div style={portalStyle}>
Expand Down
Loading