Fix x265 SIGSEGV during h265 encoding#12
Merged
Merged
Conversation
x265 build 210 changed x265_encoder_encode() to accept an array of picture pointers, then build 213 reverted this. FFmpeg n7.1 only checks `#if X265_BUILD >= 210`, so with our x265 build 215 it uses the wrong calling convention, causing a SIGSEGV during h265 encoding. Apply upstream FFmpeg fix (099f88b864) that narrows the guard to `(X265_BUILD >= 210) && (X265_BUILD < 213)`. Also adds x265 encoding test to CI to prevent regressions. Closes remotion-dev/remotion#6630 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x265_encoder_encode()API to accept an array of picture pointers (for multi-layer encoding), then build 213 reverted this back. FFmpeg n7.1 guards with#if X265_BUILD >= 210, so with our x265 build 215 it uses the wrong calling convention, causing a segfault.(X265_BUILD >= 210) && (X265_BUILD < 213)Test plan
test-ffmpeg.mjsx265 encoding test onbuild-linux-x64-gnu)🤖 Generated with Claude Code