Add cutoffs parameter to nice_fit() for controlling fit index cutoffs display#42
Draft
Add cutoffs parameter to nice_fit() for controlling fit index cutoffs display#42
Conversation
… display Co-authored-by: rempsyc <13123390+rempsyc@users.noreply.github.com>
…n and references Co-authored-by: rempsyc <13123390+rempsyc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] nice_fit() index cutoffs
Add cutoffs parameter to nice_fit() for controlling fit index cutoffs display
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses JOSS review feedback regarding the
nice_fit()function's handling of fit index cutoffs and documentation accuracy.Key Changes
Added
cutoffsparameter for explicit control over cutoff display:Updated terminology from "Common guidelines" to "Suggested cutoffs" in the table footer to better reflect the nature of these values.
Enhanced documentation with:
@param cutoffsdescription explaining the new parameter@referencessectionguidelinesandcutoffsparametersMaintained full backward compatibility - the
cutoffsparameter defaults to the same value asguidelines, so existing code behavior is unchanged.Validation
cutoffsparameter functionalityImpact
This change gives users fine-grained control over cutoff display while addressing the JOSS review concerns about cutoff misuse. Users can now hide potentially misleading cutoffs while retaining the nice table formatting, which aligns with best practices for structural equation modeling.
The implementation respects the existing Jorgensen quote warning in the documentation while providing practical flexibility for users who understand the limitations of cutoffs but still find them useful as rough guidelines.
Fixes #21.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.