adds ext section for better dependency managment, replaces deprecated…#29
adds ext section for better dependency managment, replaces deprecated…#29jkwiecien wants to merge 4 commits intorenaudcerrato:masterfrom
Conversation
… keywords with a new ones, updates support lib and target and compile sdk
library/build.gradle
Outdated
| @@ -1,14 +1,15 @@ | |||
| apply plugin: 'com.android.library' | |||
| apply plugin: 'com.github.dcendents.android-maven' | |||
|
Thanks @jkwiecien, but there's quite a few cleanup required before merging that PR :
|
|
How would I solve the whitespaces problem? You probably used some custom code style formatter while I'm using the default AS one. Is your custom formatter part of the repo? |
|
@jkwiecien : just don't |
|
There is for sure at least one source file updated on purpose |
|
I just checked. There were files updated for a reason. Just the change got lost in a crowd of white spaces, because as said before, you were using some custom format. You'll have to add it to the repo if you want me to fix it. |
|
Mmmm... I'm not using any custom formater for the exact reason we're experiencing now : that mess with PR when contributing. Let's forget about the whitespaces, but what's about the unwanted plugin and gradle folder? |
|
Deleted the unwanted gradle files from sample module. You should double check your code style formatter because I' pretty sure it's a custom one. |
| } | ||
|
|
||
| static private Drawable unwrap(Drawable icon) { | ||
| if(icon instanceof android.support.v7.graphics.drawable.DrawableWrapper) |
There was a problem hiding this comment.
This is the part that was crashing, I'm not sure why the conditions were here, maybe you got some valid reasons, however, some of these classes/methods are not accessible anymore
This fixes #28 by:
In the process also updated build tools, compile and target sdk, and added some shared variables in global build.gradle