Move site_vars to templates/site_vars.html#17
Merged
john0isaac merged 1 commit intorender-engine:mainfrom Apr 27, 2025
Merged
Conversation
Collaborator
Member
|
@kjaymiller I think we agreed that it's better to separate the settings.py SITE_VARS = {
...
} and in and app.site_vars.update(SITE_VARS) This PR only separates them in rendering but after cookiecutter resolves it it's the same output. |
Collaborator
|
@john0isaac - I think this can still be merged and we can add the additional structure in a separate PR. |
kjaymiller
approved these changes
Dec 9, 2024
Collaborator
john0isaac
approved these changes
Dec 9, 2024
Member
john0isaac
left a comment
There was a problem hiding this comment.
@calismu can you rebase your branch so the tests run? if the tests pass successfully we will merge the PR
5600684 to
606649c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13