Improve editor to prevent layout breakage#14
Open
timlandolt wants to merge 22 commits into
Open
Conversation
schmijos
reviewed
Jun 24, 2026
schmijos
left a comment
schmijos
left a comment
Member
There was a problem hiding this comment.
The system tests are still missing? How do you prove to me that "it still all works"?
| params.append("template[render_path][]", p), | ||
| ); | ||
|
|
||
| return `/ferbe/template/edit?${params.toString()}`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET-25970
Now, opening a template will open a completely new page containing the content as an
iframeas well as the editor.This also allowed me to remove the error handling logic, as now the templates can still be edited with errors.
Opening the editor now works using a custom JS event that will open the whole new page if not opened yet. Otherwise, it will replace the editor using a turbo stream.
Other changes:
hostfor the host application andapplicationfor the engine views.display: content;to make the custom elements less invasive (can be seen with the newly added "grid" in the dummy app)