Add My ratings overview page#16
Merged
Merged
Conversation
rnestler
reviewed
Jun 23, 2026
Comment on lines
+8
to
+10
| get 'tech_radar/ratings', to: 'tech_radar_ratings#index', as: :tech_radar_ratings | ||
| patch 'tech_radar/ratings/:technology_id', | ||
| to: 'tech_radar_ratings#save', as: :save_tech_radar_rating |
Member
There was a problem hiding this comment.
Use the regular CRUD routes (as you already do below) instead of inventing your own index:
https://guides.rubyonrails.org/getting_started.html#crud-routes
rnestler
reviewed
Jun 23, 2026
| @@ -4,22 +4,33 @@ class TechRadarRatingsController < ApplicationController | |||
Member
There was a problem hiding this comment.
Probably makes sense to rename this to TechRader::RatingsController and then consequently use tech_radar/rating routes.
ddbrendan
force-pushed
the
ratings-overview
branch
2 times, most recently
from
825e027 to
ae2278b
Compare
rnestler
reviewed
Jun 25, 2026
Comment on lines
+8
to
+17
| namespace :tech_radar do | ||
| resources :ratings, only: [:index], param: :technology_id do | ||
| patch :save, on: :member | ||
| end | ||
| end | ||
|
|
||
| resource :tech_radar_rating, | ||
| only: [:show, :update], | ||
| path: 'tech_radar/rate', | ||
| controller: 'tech_radar_ratings' do | ||
| controller: 'tech_radar/ratings' do |
Member
There was a problem hiding this comment.
And now put all routes in the ratings resource above. (Also the two posts below o.c.)
ddbrendan
force-pushed
the
ratings-overview
branch
from
ae2278b to
da5d9e9
Compare
firemind
reviewed
Jun 26, 2026
firemind
reviewed
Jun 26, 2026
firemind
reviewed
Jun 26, 2026
firemind
reviewed
Jun 26, 2026
firemind
reviewed
Jun 26, 2026
firemind
reviewed
Jun 26, 2026
firemind
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will also add pagination soon. I was also thinking about adding a button here to enter the Karteikarten mode so the user can go through each of his ratings one by one and update them if needed. What do you think?