Add size option to choose size with pixels - #31
Draft
bfirsh wants to merge 1 commit into
Draft
Conversation
bfirsh
force-pushed
the
add-size-option
branch
from
October 9, 2024 15:51
0e0d866 to
3820c0a
Compare
daanelson
reviewed
Oct 9, 2024
| # 1 megapixel sizes | ||
| SIZES = {f"{x}x{y}": (x, y) for x, y in ASPECT_RATIOS.values()} | ||
| # 0.25 megapixel sizes | ||
| SIZES.update({f"{x / 2}x{y / 2}": (x / 2, y / 2) for x, y in ASPECT_RATIOS.values()}) |
Contributor
There was a problem hiding this comment.
minor thing - this should be integer division {x // 2}. if it's {x / 2} then we'll have a trailing .0 on all the strings, e.g. 512.0 instead of 512.
daanelson
reviewed
Oct 9, 2024
| if aspect_ratio is not None or megapixels is not None: | ||
| # set defaults | ||
| if aspect_ratio is None: | ||
| aspect_ratio = "1024x1024" |
Contributor
There was a problem hiding this comment.
this is off, aspect_ratio should default to 1:1 not 1024x1024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.