fix: support Docker daemon over SSH (DOCKER_HOST=ssh://...)#3078
Open
lucklove wants to merge 1 commit into
Open
fix: support Docker daemon over SSH (DOCKER_HOST=ssh://...)#3078lucklove wants to merge 1 commit into
lucklove wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
DOCKER_HOSTor the active Docker context is set to an SSH endpoint (e.g.ssh://user@host),cogfails with:The root cause is that the Docker Go SDK's
client.WithHost()does not understand thessh://scheme — it attempts a plain TCP/HTTP connection instead of tunneling over SSH.The standard
dockerCLI handles this transparently viaconnhelper.GetConnectionHelper(), which returns an SSH-based dialer forssh://hosts.Fix
After building the
dockerClientOptsslice, callconnhelper.GetConnectionHelper(host). If the host is an SSH URL, inject the returned SSH dialer viaclient.WithDialContext. This mirrors how the official Docker CLI handles remote SSH daemons.github.com/docker/cliis already a dependency, so no new dependencies are introduced.Testing
pkg/dockertests all passcog buildworks against a remote Docker daemon viaDOCKER_HOST=ssh://root@<host>