TDD - Roberta Amaro#23
Open
robs-am wants to merge 9 commits into
Open
Conversation
Comment on lines
+20
to
+33
| function withdraw(withdraw) { | ||
| if (withdraw <= balance) { | ||
| balance = balance - withdraw; | ||
| return "Saque efetuado"; | ||
| } else { | ||
| if (withdraw <= limit) { | ||
| balance = balance - limit; | ||
| //return balance; | ||
| return "Saldo negativo e limite disponível"; | ||
| } else { | ||
| return "Operação Negada"; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Você poderia incluir nas mensagens de retorno o valor do novo saldo após o saque realizado.
Comment on lines
+17
to
+24
| it("should enable withdraw when sufficient balance", () => { | ||
| const output = "Saque efetuado"; | ||
| expect(withdraw(100)).toEqual(output); | ||
| }); | ||
| it("should enable withdraw when insufficient balance and the limit is sufficient", () => { | ||
| const output = "Saldo negativo e limite disponível"; | ||
| expect(withdraw(1005)).toEqual(output); | ||
| }); |
There was a problem hiding this comment.
Você poderia fazer outro teste referente à função withdraw para verificar quando o cliente não possui nem saldo nem limite suficientes, que no caso iria retornar "Operação Negada".
Marianaliima
reviewed
Jul 3, 2023
Marianaliima
left a comment
Marianaliima
left a comment
Collaborator
There was a problem hiding this comment.
olá, parabéns pela entrega, seria bom refatorar os testes para usar variavas globais
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolução de testes unitários para verificação de uma conta bancária
Como?