Atividade S1 Conta Bancária - Bruna Andrade#24
Open
brunardosanjos wants to merge 3 commits into
Open
Conversation
hinale
reviewed
Jun 30, 2023
|
|
||
| if ( | ||
| this.balance >= value || | ||
| (this.balance < value && balanceAvailable >= value && this.status == true) |
There was a problem hiding this comment.
Neste caso, não está levando em consideração quando ele usa o limite, pois no exercício diz que quando o valor do saldo é insuficiente pode ser usado o limite e o saldo fica negativo com o uso do limite.
Poderia ser usado uma nova condição para quando o limite for usado.
|
Considerações:
|
Marianaliima
reviewed
Jul 3, 2023
Marianaliima
left a comment
Marianaliima
left a comment
Collaborator
There was a problem hiding this comment.
parabéns pelo teste e a lógica usada nas funções, senti falta de uma construção de testes para casos negativos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.