Entrega de atividade - semana 1#30
Open
rddavino wants to merge 2 commits into
Open
Conversation
Marianaliima
reviewed
Jul 3, 2023
Marianaliima
left a comment
Marianaliima
left a comment
Collaborator
There was a problem hiding this comment.
olá tudo bem? Parabéns pela entrega do trabalho, sobre os testes um desafio seria refatorar para melhor legibilidade, exemplo tem um describe geral que está vazio, será que seria necessário?
There was a problem hiding this comment.
Oii Raquel, muito bacana que você separou as funções para cada operação bancária! Mas eu senti falta de mais alguns cenários de testes, por exemplo na função checkBankAccountBalance() verificar saldos negativos. Ou na função deposit(depositValue) verificar se o valor depositado é zero ou negativo para não ser permitido etc.
Bons estudos. :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entregando atividade da primeira semana