WIP: Ability to use ssl_min_version and/or ssl_max_version instead of ssl_method#6
Open
emiran-orange wants to merge 3 commits intoreproio:masterfrom
Open
WIP: Ability to use ssl_min_version and/or ssl_max_version instead of ssl_method#6emiran-orange wants to merge 3 commits intoreproio:masterfrom
emiran-orange wants to merge 3 commits intoreproio:masterfrom
Conversation
emiran-orange
force-pushed
the
min_max_version
branch
from
9476f23 to
14959a9
Compare
emiran-orange
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl_methodparam can only be used up to TLS 1.2 version in openssl (as stated in ruby/openssl#473 (comment)).This PR introduces params
ssl_min_versionandssl_max_version.If neither of these is set, the current behaviour still stands and
ssl_methodparam is used.Otherwise,
ssl_min_versionandssl_max_versionare passed to ssl context.