fix: use removesuffix("Def") instead of [:-3] for elementKind extraction#63
Merged
fix: use removesuffix("Def") instead of [:-3] for elementKind extraction#63
removesuffix("Def") instead of [:-3] for elementKind extraction#63Conversation
Copilot
AI
changed the title
[WIP] Drop support for Python 3.10–3.12 and require Python 3.13
fix: use Mar 1, 2026
removesuffix("Def") instead of [:-3] for elementKind extraction
fec4221 to
69b3b82
Compare
Co-authored-by: jimisola <1577689+jimisola@users.noreply.github.com>
79a0bfe to
2a2c30d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node.__class__.__name__[:-3]used a magic number to strip"Def"from AST node class names (FunctionDef,AsyncFunctionDef,ClassDef). While correct, it silently truncates incorrectly for any class name not ending in exactly 3 chars.Change
[:-3]with.removesuffix("Def")— explicit about what's being stripped, no-op for names that don't end in"Def"🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.