Conversation
|
Looks good, have you tested it locally? I had some problems with the previous version of the plugin executing too early during the build process and it seemed like it was not possible to configure it to run later. I assume this is not an issue now? |
@lfvdavid Please confirm that this works locally for you as well. Then I convinced that I can merge it to main. |
… run on install command
|
Plugin works now after a few tweaks. When updating the pyproject.toml with new includes during poetry build command poetry has already read the file and any changes made is not included (for that build). Added a check for InstallCommand and we are now adding the includes when running poetry install instead. We did not check if the includes was already added, so every build command would add duplicate includes, fixed this by checking the existing includes before adding new ones. Also added a cleanup of the pyproject.toml file to remove excessive new lines. |
I'm not following here. The sdist needs to be updated during build to my knowledge so that the sdist has the reqstool files. let's take it in person next week. have a nice weekend |
|
After discussing how we want the plugin to work: If possible, when running The main issue here that we need to figure out is when the build command is running any changes made to the
This will make the plugin more dynamic and reduces the chance for miss-configuration. |
|
Superseded by #98 which implemented and extended these improvements (ApplicationPlugin refactor, event-driven hooks, TOML/YAML bug fix, docs update, test fixture). All changes are now on main. |
Reworked the plugin quite a bit. It's not an application plugin instead of a generic plugin.
This allows the plugin to only do its stuff when
poetry buildis executed and not will all poetry commands as before.I also made the plugin a bit less noisy.
ping @lfvdavid