fix: show human-readable labels in delete confirmation prompts

[bukinoshita]

Summary by cubic

Show human-readable labels in delete confirmations across all CLI delete commands to prevent mistakes. Satisfies BU-653 by showing the selected label plus the ID.

• Bug Fixes
  • Added pickItem() in prompts to return { id, label }; pickId() now delegates to it for compatibility.
  • Updated 9 delete commands to use pickItem() and display "${label}" with ID: ${id} in confirmation prompts.
  • Added 4 tests for pickItem() covering direct ID, non-interactive, and optional flows.

^{Written for commit fb55bba. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 11 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/commands/segments/delete.ts">

<violation number="1" location="src/commands/segments/delete.ts:38">
P2: Escape control characters in `picked.label` before showing it in the delete confirmation prompt.</violation>
</file>

<file name="src/lib/prompts.ts">

<violation number="1" location="src/lib/prompts.ts:272">
P2: Direct ID input still uses the raw ID as `label`, so confirmations show the ID twice instead of a human-readable identifier.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P2: Escape control characters in picked.label before showing it in the delete confirmation prompt.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/commands/segments/delete.ts, line 38:

<comment>Escape control characters in `picked.label` before showing it in the delete confirmation prompt.</comment>

<file context>
@@ -30,16 +30,16 @@ Non-interactive: --yes is required to confirm deletion when stdin/stdout is not
       !!opts.yes,
       {
-        confirmMessage: `Delete segment ${id}?\nContacts will not be deleted, but broadcasts targeting this segment will no longer work.`,
+        confirmMessage: `Delete segment "${picked.label}"?\nID: ${picked.id}\nContacts will not be deleted, but broadcasts targeting this segment will no longer work.`,
         loading: 'Deleting segment...',
         object: 'segment',
</file context>

[cubic-dev-ai]

P2: Direct ID input still uses the raw ID as label, so confirmations show the ID twice instead of a human-readable identifier.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/prompts.ts, line 272:

<comment>Direct ID input still uses the raw ID as `label`, so confirmations show the ID twice instead of a human-readable identifier.</comment>

<file context>
@@ -249,25 +249,27 @@ export type PickerConfig<T extends { id: string }> = {
+): Promise<PickedItem | undefined> {
   if (id) {
-    return id;
+    return { id, label: id };
   }
 
</file context>