Add support for Guzzle 8#118
Draft
GrahamCampbell wants to merge 1 commit into
Draft
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: This PR updates dependency constraints to allow Guzzle 8, adds missing required dependencies, and refactors response body retrieval to avoid consuming the stream prematurely, with a corresponding test; all changes are low-risk and isolated to the HTTP transporter.
Re-trigger cubic
Collaborator
|
Thank you @GrahamCampbell. Really appreciate a PR coming from you 🖤 |
Author
|
Whoops, meant to send this as draft, to be converted to non-draft when Guzzle 8.0.0 actually releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Guzzle 8, adds in missing dependencies you were explicitly using but forgot to add explicit dependencies on, and bound the minimum versions to avoid super old versions.
FYI, the Guzzle 8.0.0 release is tentatively planned for early Q3. I am sending this PR as part of both validating that key packages can upgrade to Guzzle 8, and to actually get them upgraded. This package was identified as a key ecosystem package either because it is a widely used package or because it is a dependency of Laravel. This PR is not suitable to merge until Guzzle 8.0.0's actually released.