Avoid metaprogramming when bulk setting attributes.#2
Open
Avoid metaprogramming when bulk setting attributes.#2
Conversation
We extract key normalisation from `method_missing` so we can use it in `[]=`, so that `attributes=` does not have to go through `method_missing` to get to `set_attribute`. On my local this yields a ~20% decrease in deserialization time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We extract key normalisation from
method_missingso we can use it in[]=, so thatattributes=does not have to go throughmethod_missingto get toset_attribute.On my local this yields a ~20% decrease in deserialization time.
This has passed unit tests on my local, and I've tested guide creation, which @joeforshaw noticed was broken after the last perf attempt on this module. 😹