docs(rust): API reference master#65
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughRestructures Rust SDK documentation from flat top-level files into granular nested module pages. Updated navigation manifests ( ChangesRust SDK Documentation Restructuring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request significantly expands the auto-generated API documentation for the Rust SDKs, replacing high-level crate summaries with granular, module-level documentation for resq-ai, resq-bin, resq-cli, resq-dsa, and resq-tui. The review feedback highlights several systemic issues with the documentation generator, including the generation of invalid Rust syntax for generic bounds, the exposure of internal implementation details (such as Serde's private types), and malformed trait implementation signatures. Additionally, some summaries are truncated, and it is recommended to fix these at the source-level doc comments to ensure persistence across regeneration cycles.
|
|
||
| - `fn new(capacity: usize, error_rate: f64) -> Self` - Creates a new Bloom filter with the given capacity and error rate. | ||
| - `fn from_raw_params(bit_count: usize, hash_count: usize) -> Self` - Creates a new Bloom filter from pre-computed parameters. | ||
| - `fn add<impl AsRef<[u8]>>(self: & mut Self, item: impl Trait)` - Adds an element to the filter. |
There was a problem hiding this comment.
The generated signature for add contains invalid Rust syntax (<impl AsRef<[u8]>>) and an unresolved placeholder (impl Trait). This indicates a systemic issue in the documentation generator's handling of generic bounds and trait implementations.
This should be addressed in the generator logic to ensure that API references for generic methods are rendered correctly across the SDK.
| **Trait Implementations:** | ||
|
|
||
| - **Deserialize** | ||
| - `fn deserialize<__D>(__deserializer: __D) -> _serde::__private228::Result<Self, <__D as >::Error>` |
There was a problem hiding this comment.
|
|
||
| **Functions** | ||
|
|
||
| - [`hook_content`](#hook_content) - Returns the canonical content for a given hook name, or `None` if the |
There was a problem hiding this comment.
The summary for hook_content in the Contents section is truncated ("...or None if the"). This usually happens when the generator only captures the first line of a doc comment.
As per the general rules, please apply the fix to the source-level documentation (e.g., the Rust doc comments) by ensuring the first sentence is concise and fits on a single line.
References
- When fixing errors in auto-generated documentation, apply the changes to the source-level documentation (e.g., XML doc comments) instead of the generated files to ensure the fixes persist across regeneration cycles.
| - **Drop** | ||
| - `fn drop(self: & mut Self)` | ||
| - **DerefMut** | ||
| - `fn deref_mut(self: & mut Self) -> & mut <Self as >::Target` |
There was a problem hiding this comment.
Auto-generated by
API docs (Rust)inresq-software/cratesfor refmaster(run: 25624650511).
Regenerated stub pages under
sdks/rust/api/. Each pageembeds the crate's README and links to docs.rs for the
canonical API reference.
Summary by CodeRabbit
Rust SDK Documentation Update