Skip to content

chore: sync from monorepo @46bbacc #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WomB0ComB0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: sync from monorepo @46bbacc #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@

<!-- gRPC / Protobuf -->
<PackageVersion Include="Google.Protobuf" Version="3.34.1" />
<PackageVersion Include="Grpc.Net.Client" Version="2.76.0" />
<PackageVersion Include="Grpc.Net.Client" Version="2.80.0" />
<PackageVersion Include="Grpc.Tools" Version="2.80.0" />

<!-- Service Clients & HTTP -->
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Http.Polly" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.6" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.7" />
<PackageVersion Include="Microsoft.Extensions.Http.Polly" Version="10.0.7" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.7" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.7" />
<PackageVersion Include="Polly" Version="8.6.6" />
<PackageVersion Include="Polly.Extensions.Http" Version="3.0.0" />
<PackageVersion Include="System.Text.Json" Version="9.0.14" />
<PackageVersion Include="System.Text.Json" Version="9.0.15" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />

<!-- Blockchain -->
Expand Down
1 change: 1 addition & 0 deletions ResQ.Blockchain/ResQ.Blockchain.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<PackageReference Include="Neo" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Options" />
<PackageReference Include="System.Text.Json" />
</ItemGroup>

</Project>
1 change: 1 addition & 0 deletions packages/ResQ.Blockchain/ResQ.Blockchain.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PackageReference Include="Neo" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Options" />
<PackageReference Include="System.Text.Json" VersionOverride="9.0.15" />
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The VersionOverride="9.0.15" is redundant because it matches the version defined in Directory.Packages.props. Additionally, the indentation should be corrected to 4 spaces to maintain consistency.

    <PackageReference Include="System.Text.Json" />

</ItemGroup>

</Project>
1 change: 1 addition & 0 deletions packages/ResQ.Protocols/ResQ.Protocols.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PackageReference Include="Google.Protobuf" />
<PackageReference Include="Grpc.Net.Client" />
<PackageReference Include="Grpc.Tools" PrivateAssets="All" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" VersionOverride="8.0.3" />
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Overriding Microsoft.Extensions.Logging.Abstractions to version 8.0.3 is a significant downgrade from the centrally managed version 10.0.7. This can cause dependency conflicts and runtime issues. Unless there is a specific requirement for this legacy version, it should be removed to align with the rest of the solution. Also, the indentation should be 8 spaces to match the existing items in this group.

        <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />

</ItemGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions resq-core/ResQ.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" VersionOverride="8.0.3" />
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This project is overriding Microsoft.Extensions.Logging.Abstractions to version 8.0.3, which is inconsistent with the central version 10.0.7. This downgrade should be avoided to prevent potential 'diamond dependency' issues. The indentation also needs to be corrected to 4 spaces.

    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />

</ItemGroup>

<ItemGroup>
Expand Down
Loading