-
Notifications
You must be signed in to change notification settings - Fork 0
chore(security): triage Cargo OSV advisories — 6 fixed, 7 documented #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
24b7e21
chore(security): triage Cargo OSV advisories — 6 fixed, 7 documented
WomB0ComB0 4d0d9e7
fix(security): osv-scanner key snake_case + cover vendor/ advisories …
WomB0ComB0 1515e03
fix(security): revert osv-scanner key to PascalCase — gemini advice w…
WomB0ComB0 f49b44a
fix(security): per-lockfile osv-scanner configs (vendor needs its own)
WomB0ComB0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # OSV-Scanner configuration for resq-software/programs. | ||
| # | ||
| # Each [[IgnoredVulns]] block carries a rationale for why the advisory cannot | ||
| # be fixed in this workspace today. Revisit on any Solana / Anchor major bump. | ||
| # | ||
| # Format: https://google.github.io/osv-scanner/configuration/ | ||
| # Note: OSV-Scanner v2 expects PascalCase keys (IgnoredVulns); snake_case is rejected. | ||
|
|
||
| # ── Unmaintained-crate advisories (informational, no known exploit) ────────── | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2025-0141" | ||
| # bincode 1.3.3 is unmaintained; bincode 2.x is available but breaks the | ||
| # Anchor 1.0.0-rc.2 serialization API. Blocked on Anchor upstream migration. | ||
| reason = "bincode 1.x transitive via anchor-lang; await upstream Anchor bump to bincode 2.x" | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2024-0388" | ||
| # derivative is unmaintained. Transitive via anchor-lang's macro machinery. | ||
| reason = "derivative 2.2.0 transitive via anchor-lang; await upstream migration to derive-more or similar" | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2024-0436" | ||
| # paste is unmaintained. Transitive via anchor-lang macros. | ||
| reason = "paste 1.0.15 transitive via anchor-lang macros; await upstream migration" | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2025-0161" | ||
| # libsecp256k1 0.6.0 is effectively frozen; Solana pins this version. | ||
| reason = "libsecp256k1 0.6.0 transitive via solana-* crates; fix requires upstream Solana bump" | ||
|
|
||
| # ── Old dalek / rand pins (transitive via Solana; on-chain BPF unaffected) ─── | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2024-0344" | ||
| # curve25519-dalek 3.2.0 has a timing side channel in Scalar::from_canonical_bytes. | ||
| # Pinned by solana-zk-token-sdk and older solana-program versions which we pull | ||
| # transitively. On-chain BPF code does not execute this crate (programs verify | ||
| # via syscalls, not userspace dalek). Risk is confined to host-side tests. | ||
| reason = "curve25519-dalek 3.2.0 transitive via solana-zk-token-sdk; on-chain BPF unaffected; await upstream Solana bump to dalek 4.x across the stack" | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2022-0093" | ||
| # ed25519-dalek 1.0.1 has a signature-oracle vulnerability in specific API misuse | ||
| # patterns. Programs in this workspace never call ed25519-dalek directly; it comes | ||
| # in via vendored solana-program-test (a dev-dependency only). | ||
| reason = "ed25519-dalek 1.0.1 transitive via vendored solana-program-test (dev-dep only); on-chain programs do not call dalek directly" | ||
|
|
||
| [[IgnoredVulns]] | ||
| id = "RUSTSEC-2026-0097" | ||
| # rand 0.7.3 is unsound when rand::rng() is called with a custom logger installed. | ||
| # We pin rand 0.7.3 only transitively via old solana-* deps. No workspace code uses | ||
| # custom loggers with rand; the 0.8.x and 0.9.x pins are already on fixed versions. | ||
| reason = "rand 0.7.3 transitive via solana-* deps; fixed versions (0.8.6, 0.9.3) already pinned for first-order users; no custom-logger code paths" | ||
|
|
||
| # Vendor-only advisories live in vendor/solana-program-test/osv-scanner.toml. | ||
| # OSV-scanner treats each discovered lockfile directory as its own scan-config | ||
| # scope, so vendor entries here would be reported as "unused ignores". | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.