Revised Macro Refactor: Impl Block Support and Backward Compatibility (#43)#67
Open
BigFish2086 wants to merge 5 commits intorestatedev:mainfrom
Open
Revised Macro Refactor: Impl Block Support and Backward Compatibility (#43)#67BigFish2086 wants to merge 5 commits intorestatedev:mainfrom
BigFish2086 wants to merge 5 commits intorestatedev:mainfrom
Conversation
- updated Cargo.toml to have mutliple binaries, one that used
the old macro trait-syntax, and another one for the new macro
struct-impl syntax, so we can test them later, so now
`cargo build -p test-services` would generate 2 binaries
trait-test-services & impl-test-services
- updated Dockerfile:
- to cache the building process through the new mount syntax as well
as building in multiple stages
- to have a --build-arg which is BIN that deteremins which macro
syntax to test when running the restate-sdk-test-suite.jar
Contributor
|
Hey @BigFish2086 i'm posting some considerations on the issue #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #43 by refactoring the
restate-sdk-rustmacros to apply directly toimplblocks instead of requiring separate trait definitions. The change improves ergonomics, eliminates the need forFooBar/FooBarImplnaming conventions, and aligns the SDK with more idiomatic Rust patterns.Current Macros:
#[service],#[object], and#[workflow]with support for optional attributes likevis = "pub"which is needed to control the visibility of the generatedServeandClientstructs andname = "my_service"for overriding the service name.#[handler]to mark which of the methods are service handlers. It also supports optional attributes likename = "my_handler"to override the handler name andsharedin case of having anObjector aWorkflowto support concurrent use of the handler.Example:
However, this "Redo" keeps the old syntax valid as well for backword compitability, so this still works as before: