feat: include devDependencies in build#60
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the dependency topology builder to include devDependencies alongside regular and peer dependencies.
- Added
devDependenciesfield toPackageFiletype - Updated
getDependencyTopoto merge and sortdevDependencies - Added a test case verifying devDependencies are included in the topology
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shared/dependency-topo.ts | Added devDependencies to type and merged into sorting |
| src/shared/dependency-topo.test.ts | New test to cover inclusion of devDependencies |
| export function getDependencyTopo<T extends PackageMeta>(list: T[]): (T & Topology)[] { | ||
| const packages = Object.fromEntries(list.map(item => { | ||
| const { config: { name, dependencies, peerDependencies } } = item | ||
| const { config: { name, dependencies, devDependencies, peerDependencies } } = item |
There was a problem hiding this comment.
When destructuring optional dependency objects, provide defaults to avoid runtime errors (e.g., dependencies = {}, devDependencies = {}, peerDependencies = {}).
| const { config: { name, dependencies, devDependencies, peerDependencies } } = item | |
| const { config: { name, dependencies = {}, devDependencies = {}, peerDependencies = {} } } = item |
| const packages = Object.fromEntries(list.map(item => { | ||
| const { config: { name, dependencies, peerDependencies } } = item | ||
| const { config: { name, dependencies, devDependencies, peerDependencies } } = item | ||
|
|
||
| return [name, { | ||
| ...item, | ||
| dependencies: Object.keys({ ...dependencies, ...peerDependencies }) | ||
| dependencies: Object.keys({ ...dependencies, ...devDependencies, ...peerDependencies }) | ||
| .filter(dependencyName => list.map(({ config }) => config.name).includes(dependencyName)) |
There was a problem hiding this comment.
[nitpick] Avoid rebuilding the package name list on every filter iteration; precompute a Set of valid package names before mapping to achieve O(1) lookups.
|
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related Issues
Checklist
Additional Notes