feat: add onPause and onResume hooks to pause and resume the camera#2
Open
victor141516 wants to merge 2 commits intomasterfrom
Open
feat: add onPause and onResume hooks to pause and resume the camera#2victor141516 wants to merge 2 commits intomasterfrom
victor141516 wants to merge 2 commits intomasterfrom
Conversation
victor141516
force-pushed
the
add-pause-camera-button
branch
from
1367a67 to
33c8960
Compare
victor141516
changed the title
beavis
reviewed
Jun 24, 2022
Comment on lines
+225
to
+246
| @Override | ||
| protected void onPause () { | ||
| super.onPause(); | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
| myWebView.postWebMessage( | ||
| new WebMessage("{\"type\": \"setCameraPause\", \"payload\": true}"), | ||
| Uri.parse(REVIEVE_CDN_DOMAIN) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected void onResume () { | ||
| super.onResume(); | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
| myWebView.postWebMessage( | ||
| new WebMessage("{\"type\": \"setCameraPause\", \"payload\": false}"), | ||
| Uri.parse(REVIEVE_CDN_DOMAIN) | ||
| ); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think it would be great to comment in the code why they might want to use this snippet and also mention webview.pause / resume alternatives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds and example of the usage of https://github.com/revieve/revieve-web-plugin-4/pull/718
It's a new API method that pauses/resumes the liverAR camera. In the android app that's toggled when the app goes to background or foreground.
Here is the APK: https://revieve.slack.com/files/U03DTCL5PJ6/F03L1VDFSMV/app-debug.apk