Draft
Conversation
aleclearmind
requested changes
Apr 22, 2021
fcremo
force-pushed
the
feature/windows
branch
3 times, most recently
from
8501d1e to
013718c
Compare
With this commit libc-headers becomes a standalone component, separate from the libc-extra-libraries one. The libc-extra-libraries component uses `orc inspect` to list and delete the files already provided by libc-headers component avoiding overlaps.
It's required to successfully build LLVM for Windows.
It breaks Windows builds.
Contributor
|
Update for when you resume working on this: I've pushed on this repository Notes:
Things that need to be done:
Some of this tasks call for a more in depth handling of cross-compiling components, but I'd like to postpone that. |
fcremo
commented
Jul 13, 2021
Comment on lines
+38
to
+40
| (@ else: @) | ||
| make -j16 | ||
| (@ end @) |
Author
There was a problem hiding this comment.
The part setting install content in case ! is_windows is useless, we can just leave build_system: make
Comment on lines
+38
to
40
| (@= cmake(additional_cmake_args=cmake_opts) @) \ | ||
| "(@= source_dir @)/llvm" \ | ||
| -GNinja \ | ||
| -DCMAKE_BUILD_RPATH="\$ORIGIN/../lib:$ORCHESTRA_ROOT/lib" \ | ||
| -DCMAKE_INSTALL_RPATH="$RPATH_PLACEHOLDER/lib" \ | ||
| -DCMAKE_BUILD_TYPE="(@= cmake_build_type @)" \ | ||
| -DCMAKE_EXE_LINKER_FLAGS="(@= cflags @)" \ | ||
| -DCMAKE_SHARED_LINKER_FLAGS="(@= cflags @)" \ | ||
| -DCMAKE_MODULE_LINKER_FLAGS="(@= cflags @)" \ | ||
| -DCMAKE_CXX_FLAGS="(@= cflags @)" \ | ||
| -DLLVM_TARGETS_TO_BUILD="AArch64;AMDGPU;ARM;Mips;SystemZ;X86" \ | ||
| -DLLVM_ENABLE_DUMP=ON \ | ||
| -DLLVM_ENABLE_TERMINFO=OFF \ | ||
| -DLIBCXX_ENABLE_ABI_LINKER_SCRIPT=OFF \ | ||
| -DCMAKE_CXX_STANDARD=20 \ |
Author
There was a problem hiding this comment.
Is there a reason why CMAKE_CXX_STANDARD is defined here and not by default_cmake_options or additional_cmake_options?
Contributor
|
We need to integrate the precious suggestions by mstorsjo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds/fixes Windows builds for:
It also switches the libcs from having a special
@headersbuild to depending on a separate component for the headers (this was required by mingw which had to be installed in three phases).Note: requires features from orchestra PR revng/revng-orchestra#25