Skip to content

Bumping to go@1.22 and rhel-9.5.#1156

Closed
ybettan wants to merge 1 commit intorh-ecosystem-edge:mainfrom
ybettan:dependencies
Closed

Bumping to go@1.22 and rhel-9.5.#1156
ybettan wants to merge 1 commit intorh-ecosystem-edge:mainfrom
ybettan:dependencies

Conversation

@ybettan
Copy link
Copy Markdown
Member

@ybettan ybettan commented Jul 14, 2024

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 14, 2024

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only rh-ecosystem-edge members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:


/asign @yevgeny-shnaidman
/cc @TomerNewman

This should auto-close all the following dependency PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 14, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 5130e35
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/6784d2e05b85db00086ff060
😎 Deploy Preview https://deploy-preview-1156--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Jul 14, 2024

/assign @yevgeny-shnaidman
/cc @TomerNewman

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 14, 2024

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only rh-ecosystem-edge members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/assign @yevgeny-shnaidman
/cc @TomerNewman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Jul 14, 2024

/hold
Additional places in the code needs to be updated with go1.22

@ybettan ybettan force-pushed the dependencies branch 2 times, most recently from ae2865c to 90d6d4b Compare July 14, 2024 07:14
@ybettan ybettan changed the title Moving to go@1.22 and bumping the api and client dependencies. Bumping to go@1.22 and rhel-9.5. Jul 14, 2024
@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Jul 14, 2024

@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Nov 25, 2024

/unhold

ybettan kernel-module-management (main) $ skopeo list-tags docker://registry.access.redhat.com/ubi9/go-toolset | grep 1\\.22
        "1.22.5",
        "1.22.5-1730550521",
        "1.22.5-1730550521-source",
        "1.22.5-1731639025",
        "1.22.5-1731639025-source",
        "1.22.5-source",

@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Nov 26, 2024

/retest

@ybettan ybettan force-pushed the dependencies branch 3 times, most recently from 3672b1e to cc359a1 Compare November 27, 2024 17:49
@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Nov 27, 2024

/retest

1 similar comment
@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Nov 27, 2024

/retest

@ybettan ybettan force-pushed the dependencies branch 4 times, most recently from 7cc1fca to 72422c1 Compare December 8, 2024 20:34
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Dec 8, 2024

@ybettan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-bundle-hub-operator-bundle 72422c1 link true /test ci-bundle-hub-operator-bundle
ci/prow/e2e 72422c1 link true /test e2e
ci/prow/images 72422c1 link true /test images
ci/prow/e2e-hub 72422c1 link true /test e2e-hub
ci/prow/ci-bundle-operator-bundle 72422c1 link true /test ci-bundle-operator-bundle
ci/prow/operator-upgrade 72422c1 link false /test operator-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Dec 9, 2024

/hold

OCP 4.18 is still shipped with go1.21 and RHEL9.4.

Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

120 files out of 284 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ybettan
Copy link
Copy Markdown
Member Author

ybettan commented Jan 13, 2025

/close

@openshift-ci openshift-ci bot closed this Jan 13, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 13, 2025

@ybettan: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ybettan ybettan deleted the dependencies branch January 13, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants